Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator: Add missing std namespace to string arguments (#242) #276

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Backport #242 to ign-msgs1

Summary

Fix homebrew build:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Use rebase and merge

Signed-off-by: Silvio <silvio@traversaro.it>
@scpeters scpeters requested a review from caguero as a code owner July 17, 2022 07:32
@github-actions github-actions bot added the Gazebo 9️ Dependency of Gazebo classic version 9 label Jul 17, 2022
scpeters added a commit to gazebo-tooling/gazebodistro that referenced this pull request Jul 17, 2022
Needed by gazebosim/gz-msgs#276

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

the windows build needs gazebo-tooling/gazebodistro#114

chapulina pushed a commit to gazebo-tooling/gazebodistro that referenced this pull request Jul 18, 2022
Needed by gazebosim/gz-msgs#276

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@chapulina chapulina enabled auto-merge (rebase) July 18, 2022 16:40
@scpeters
Copy link
Member Author

I added an ign-msgs1.yaml file in gazebo-tooling/gazebodistro#114 to try to fix the windows build, but this is still failing due to issues with popen. I'll spend a few more minutes trying to fix the windows build but will override the windows CI check to merge this if I don't see a quick fix since the issue is pre-existing, and this PR fixes the macOS build.

@chapulina
Copy link
Contributor

will override the windows CI check to merge this if I don't see a quick fix since the issue is pre-existing

SGTM, just make it not required for the ign-msgs[0-1] branch rule and remove it from gazebo-tooling/release-tools#398 so we don't need to manually override it every time.

@chapulina chapulina merged commit 73e9448 into ign-msgs1 Jul 19, 2022
@chapulina chapulina deleted the scpeters/patch_string_1 branch July 19, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gazebo 9️ Dependency of Gazebo classic version 9
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants