Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator: Add missing std namespace to string arguments (#242) #276

Merged
merged 3 commits into from
Jul 19, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/ignition/msgs/Generator.hh
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ class Generator : public CodeGenerator
/// \param[in] _generatorContext Output directory.
/// \param[in] _error Unused string value
public: virtual bool Generate(const FileDescriptor *_file,
const string &_parameter,
const std::string &_parameter,
OutputDirectory *_generatorContext,
string *_error) const;
std::string *_error) const;

// private: GOOGLE_DISALLOW_EVIL_CONSTRUCTORS(Generator);
};
Expand Down
2 changes: 1 addition & 1 deletion src/Generator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Generator::~Generator()

/////////////////////////////////////////////////
bool Generator::Generate(const FileDescriptor *_file,
const string &/*_parameter*/,
const std::string &/*_parameter*/,
OutputDirectory *_generatorContext,
std::string * /*_error*/) const
{
Expand Down