Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert message generation pipeline #361

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

mjcarroll
Copy link
Contributor

There are a few unresolved issues with the message generation pipeline. Since it is now causing downstream packages to be blocked on CI, it makes the most sense to revert for now until ready for prime time.

Related to: gazebo-release/gz-msgs10-release#4

CC: @azeey

This reverts commit 786b42a.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
This reverts commit 16de9ef.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
This reverts commit 0c78b96.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll requested a review from caguero as a code owner July 12, 2023 20:44
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #361 (87f7551) into main (786b42a) will decrease coverage by 1.47%.
The diff coverage is 96.12%.

❗ Current head 87f7551 differs from pull request most recent head 85a2b5d. Consider uploading reports for the commit 85a2b5d to get more accurate results

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   96.89%   95.43%   -1.47%     
==========================================
  Files          28       10      -18     
  Lines        1064     1030      -34     
==========================================
- Hits         1031      983      -48     
- Misses         33       47      +14     
Impacted Files Coverage Δ
include/gz/msgs/PointCloudPackedUtils.hh 84.21% <ø> (ø)
include/gz/msgs/detail/PointCloudPackedUtils.hh 94.80% <ø> (ø)
src/Generator.hh 100.00% <ø> (ø)
src/generator_main.cc 100.00% <ø> (ø)
src/gz.cc 90.00% <ø> (ø)
include/gz/msgs/Factory.hh 66.66% <66.66%> (ø)
src/Factory.cc 81.18% <81.18%> (ø)
src/Filesystem.cc 93.33% <93.33%> (ø)
src/Utility.cc 98.97% <98.97%> (ø)
src/Generator.cc 92.75% <100.00%> (ø)

@mjcarroll mjcarroll merged commit 4372e74 into main Jul 12, 2023
7 of 9 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/revert/message_generation branch July 12, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants