Added motion duration to gui_camera.proto

[jrutgeer]

🎉 New feature

Summary

Added 'duration' field to the proto, to allow to set the duration for the 'move to pose' service of the camera tracking plugin.

[azeey]

This would be a good feature to add, but unfortunately, adding a field to an existing message breaks ABI, therefore this needs to target main.

[jrutgeer]

therefore this needs to target main.

Bummer. :-)

I tried to change this, but I did not succeed. Is there some way to retarget just this change, or should I rather close this and make a new PR?

[azeey]

Looks like @mjcarroll has changed the base branch on the PR, but you'll need to run git rebase to rebase the changes onto main

[ahcorde]

You can try something like this:

git checkout main
git checkout -b jrutgeer/duration/gui_camera
git cherry-pick d5e497e365b6b585f08b896acef4a0a5d2739834
git branch -D gz-msgs10
git checkout -b gz-msgs10
git push -f origin gz-msgs10

Anyhow is a bad idea to use the branch that you are trying to modify (in this case gz-msgs10), You should use something like jrutgeer/duration/gui_camera.

[ahcorde]

friendly ping @jrutgeer

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (875c054) 97.26% compared to head (86ede3b) 97.26%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          27       27           
  Lines        1170     1170           
=======================================
  Hits         1138     1138           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ahcorde]

@osrf-jenkins run tests please!