Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MJCF default values for gravity, magnetic, and wind when not set #109

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Aug 20, 2022

🦟 Bug fix

Summary

We weren't using the correct MJCF default values for gravity, magnetic, and wind. The default for wind matches the SDFormat default so it wasn't an issue, but the other elements, especially, magnetic, had different values.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from ahcorde August 20, 2022 01:29
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #109 (0b793b4) into main (f644622) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          24       24           
  Lines        1168     1168           
=======================================
  Hits         1112     1112           
  Misses         56       56           
Impacted Files Coverage Δ
...sdformat_mjcf/mjcf_to_sdformat/converters/world.py 97.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit e353ba2 into gazebosim:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants