Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add joint conversion for fixed, continuous, revolute, prismatic, and ball types #4

Merged
merged 7 commits into from
May 10, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Apr 27, 2022

🎉 New feature

Summary

Additional joint types, such as revolute2 and universal can be implemented by using multiple joints, but I think we can leave them for a follow up PR. The remaining joint types (gearbox and screw) will also handled in a later PR.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey added 3 commits April 25, 2022 23:51
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…ball types

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from ahcorde April 27, 2022 18:53
@azeey azeey mentioned this pull request May 4, 2022
9 tasks
Base automatically changed from azeey/add_primitive_geometry to main May 10, 2022 16:19
azeey added 4 commits May 10, 2022 12:52
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #4 (20dd572) into main (0742043) will increase coverage by 3.37%.
The diff coverage is 90.27%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   83.33%   86.71%   +3.37%     
==========================================
  Files           4        5       +1     
  Lines          72      143      +71     
==========================================
+ Hits           60      124      +64     
- Misses         12       19       +7     
Impacted Files Coverage Δ
sdformat_mjcf/sdformat_mjcf/sdf_utils.py 52.17% <28.57%> (-12.54%) ⬇️
sdformat_mjcf/sdformat_mjcf/converters/joint.py 96.92% <96.92%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0742043...20dd572. Read the comment docs.

@azeey
Copy link
Collaborator Author

azeey commented May 10, 2022

Created issues #23 and #24 to track support for other joint types.

@azeey azeey changed the title Add joint conversion for fixed, continuous, revolute, prismatic, and … Add joint conversion for fixed, continuous, revolute, prismatic, and ball types May 10, 2022
@azeey azeey merged commit 9c8ccb6 into main May 10, 2022
@azeey azeey deleted the azeey/add_joint branch May 10, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants