Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Visual geoms from colliding with other geoms #75

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jun 13, 2022

🦟 Bug fix

Summary

Currently, even though we set group numbers on collision and visual geoms to display only the visuals, they still take part in the collision detection process and collide with any other geom. Setting the contype and conaffinity to 0 will ensure that they don't collide with any other geom.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #75 (a736caa) into main (481ead3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          19       19           
  Lines         862      864    +2     
=======================================
+ Hits          839      841    +2     
  Misses         23       23           
Impacted Files Coverage Δ
...at_to_mjcf/sdformat_to_mjcf/converters/geometry.py 92.30% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 481ead3...a736caa. Read the comment docs.

@azeey azeey merged commit 82fbbe2 into gazebosim:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants