Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bullet] Mesh features #178

Merged
merged 3 commits into from
Dec 15, 2020

Conversation

Lobotuerk
Copy link

@Lobotuerk Lobotuerk commented Dec 14, 2020

Mesh collision seems to be working, at least with the duck.dae model.
ezgif-3-f39e68b5f641

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #178 (9c00f1f) into bullet_classic_dev (a985842) will decrease coverage by 0.97%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           bullet_classic_dev     #178      +/-   ##
======================================================
- Coverage               78.27%   77.30%   -0.98%     
======================================================
  Files                     114      115       +1     
  Lines                    4216     4269      +53     
======================================================
  Hits                     3300     3300              
- Misses                    916      969      +53     
Impacted Files Coverage Δ
bullet/src/SDFFeatures.cc 0.00% <ø> (ø)
bullet/src/ShapeFeatures.cc 0.00% <0.00%> (ø)
bullet/src/plugin.cc 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a985842...9c00f1f. Read the comment docs.

Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

bullet/src/ShapeFeatures.cc Show resolved Hide resolved
bullet/src/ShapeFeatures.cc Show resolved Hide resolved
bullet/src/ShapeFeatures.cc Outdated Show resolved Hide resolved
Co-authored-by: Jorge Perez <j.j.perez13@hotmail.com>
@Lobotuerk Lobotuerk merged commit 68386af into bullet_classic_dev Dec 15, 2020
@Lobotuerk Lobotuerk deleted the bulletDev/lobotuerk/MeshFeatures branch December 15, 2020 18:51
Blast545 added a commit that referenced this pull request Jan 19, 2021
* Collision working

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

Co-authored-by: Jorge Perez <j.j.perez13@hotmail.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Blast545 added a commit that referenced this pull request Feb 3, 2021
* Collision working

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

Co-authored-by: Jorge Perez <j.j.perez13@hotmail.com>
Blast545 added a commit that referenced this pull request Feb 12, 2021
* Collision working

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

Co-authored-by: Jorge Perez <j.j.perez13@hotmail.com>
Blast545 added a commit that referenced this pull request Feb 12, 2021
* Collision working

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

Co-authored-by: Jorge Perez <j.j.perez13@hotmail.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Blast545 added a commit that referenced this pull request Feb 18, 2021
* Collision working

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

Co-authored-by: Jorge Perez <j.j.perez13@hotmail.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Lobotuerk added a commit that referenced this pull request May 19, 2021
* Collision working

Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>

Co-authored-by: Jorge Perez <j.j.perez13@hotmail.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
Blast545 added a commit that referenced this pull request May 20, 2021
* base and entity features
* Add base Cmake and plugin dummy feature
* Replace dummy features with base ones
* Added Simulation Features (#168)
* added features
* [Bullet] Bullet classic, Add sdf entities (#167)
* Add SDF features to build models
* Fix class inheritance problem
* Comment unused variables in this commit
* Add vector with ids of links added in a model
* Kinematics features (#169)
* Kinematic Features
* Free Group Features (#171)
* [bullet] Basic Features (#172)
* Fixed gravity, pose, and corrected some auto variables
* [Bullet] Collision Features (#173)
* Collision working
* [bullet] Add find or construct link (#175)
* Add Find or Construct Link function
* Change function to return entity instead of identity
* Remove loop creating links inside model
* [Bullet] Mesh features (#178)
* Collision working
* [bullet] Joints implementation (#190)
* Add placeholders joint features
* Iteration to add joints after links
* sdfConstructJoint math fixed
* added missing dummys
* added constraint to the world
* Change dummy functions print to debug
* fixed position
* friction
* fixed sdfLinkSearch
* Joint velocity command
* working version tunnels
* added joint position methods
* Add basic tests
* Add missing override keyword
* Updated CMake and replaced using with structs for feature lists
* Save base when adding a mesh
* deleted worlds

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants