Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage ignore file #388

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy haoyuan2019@outlook.com

New feature

Part of gz-sim#1575

Summary

Add coverage.ignore.in to ignore vendor code in code coverage report. See gz-cmake#279 for detail.

Remove vendor source files from Codecov and build/, install/, /opt/ros/ folders from the local code coverage report.

20220719165940

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added needs upstream release Blocked by a release of an upstream library QA Quality assurance. labels Jul 19, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #388 (fbd3d31) into ign-physics2 (e4cbd9d) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           ign-physics2     #388   +/-   ##
=============================================
  Coverage         83.15%   83.15%           
=============================================
  Files               108      108           
  Lines              4210     4210           
=============================================
  Hits               3501     3501           
  Misses              709      709           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4cbd9d...fbd3d31. Read the comment docs.

@chapulina chapulina requested a review from jennuine July 20, 2022 16:58
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio marked this pull request as ready for review July 25, 2022 22:22
@AzulRadio AzulRadio removed the needs upstream release Blocked by a release of an upstream library label Jul 25, 2022
@jennuine jennuine added the needs upstream release Blocked by a release of an upstream library label Jul 25, 2022
@jennuine jennuine mentioned this pull request Jul 25, 2022
5 tasks
@jennuine jennuine removed the needs upstream release Blocked by a release of an upstream library label Jul 26, 2022
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to 2.14.0?

find_package(ignition-cmake2 2.12.0 REQUIRED)

And for these PRs as well:

Signed-off-by: youhy <haoyuan2019@outlook.com>
@chapulina chapulina merged commit e0012cf into ign-physics2 Jul 27, 2022
@chapulina chapulina deleted the azulradio/codecoverage_ignore branch July 27, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel QA Quality assurance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants