-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage ignore file #279
Conversation
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated, I tested the gazebosim/gz-physics#388 PR and this file is still appearing in my local coverage report
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
fb7f098 I added a debug message & removed any potential path prefixes from the html report using PRs that are ready to test with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one final comment
Signed-off-by: youhy <haoyuan2019@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Can't wait to see the latest coverage numbers with this in!
Signed-off-by: youhy haoyuan2019@outlook.com
New feature
Part of gz-sim#1575
Summary
Allow users to add
coverage.ignore.in
each repo to ignore files for the code coverage report.Test it
coverage.ignore.in
looks like this:It can only take files. Directories will be ignored.
Then add the following line to
CMakeList.txt
of the package.Code coverage report sometimes doesn't update with the
coverage.ignore
if we read fromsource_dir
, so adding this extra step to read it from thebinary_dir
.Can be test with
gz-common
azulradio/codecoverage_ignore
branchBefore:
After:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.