Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage ignore file #689

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy haoyuan2019@outlook.com

New feature

Part of gz-sim#1575

Alternative for #684

Summary

Add coverage.ignore.in to ignore vendor code in code coverage report. See gz-cmake#279 for detail.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 27, 2022
@AzulRadio AzulRadio added QA Quality assurance. and removed 🏰 citadel Ignition Citadel labels Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #689 (feb76f4) into ign-rendering3 (0d45f75) will increase coverage by 21.97%.
The diff coverage is n/a.

❗ Current head feb76f4 differs from pull request most recent head a947600. Consider uploading reports for the commit a947600 to get more accurate results

@@                 Coverage Diff                 @@
##           ign-rendering3     #689       +/-   ##
===================================================
+ Coverage           53.38%   75.36%   +21.97%     
===================================================
  Files                 131       98       -33     
  Lines               12021     7793     -4228     
===================================================
- Hits                 6418     5873      -545     
+ Misses               5603     1920     -3683     
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️
ogre/src/OgreDynamicRenderable.cc
ogre/src/OgreRenderTargetMaterial.cc
ogre/src/OgreConversions.cc
ogre/src/OgreRayQuery.cc
ogre/src/OgreMaterialSwitcher.cc
ogre/src/OgreDynamicLines.cc
ogre/src/OgreVisual.cc
ogre/src/OgreGeometry.cc
ogre/src/OgreGaussianNoisePass.cc
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d45f75...a947600. Read the comment docs.

@AzulRadio AzulRadio added the 🏰 citadel Ignition Citadel label Jul 27, 2022
@AzulRadio AzulRadio marked this pull request as ready for review July 27, 2022 18:48
@AzulRadio AzulRadio requested a review from iche033 as a code owner July 27, 2022 18:48
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increase coverage by 21.97%. 🚀

For future reference, we're excluding ogre for now, but as a supported engine we should be re-enabling it once #683 is resolved.

@chapulina chapulina merged commit 41d1824 into ign-rendering3 Jul 27, 2022
@chapulina chapulina deleted the azulradio/coverage_ignore branch July 27, 2022 18:54
@chapulina chapulina mentioned this pull request Jul 28, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel QA Quality assurance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants