Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ 3.5.0 #327

Merged
merged 1 commit into from
May 25, 2021
Merged

⬆️ 3.5.0 #327

merged 1 commit into from
May 25, 2021

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented May 25, 2021

🎈 Release

Preparation for 3.5.0 release.

Comparison to 3.4.0: ignition-rendering3_3.4.0...ign-rendering3

Needed by gazebosim/gz-sim#825, gazebosim/gz-sim#819

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

@mjcarroll mjcarroll requested a review from iche033 as a code owner May 25, 2021 16:15
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label May 25, 2021
@mjcarroll mjcarroll changed the base branch from ign-rendering5 to ign-rendering3 May 25, 2021 16:15
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO ?

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from ahcorde May 25, 2021 16:27
@mjcarroll
Copy link
Contributor Author

DCO ?

Fixed, amended without adding -s

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #327 (8270d24) into ign-rendering3 (e14d708) will not change coverage.
The diff coverage is n/a.

❗ Current head 8270d24 differs from pull request most recent head 29a1412. Consider uploading reports for the commit 29a1412 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #327   +/-   ##
===============================================
  Coverage           53.21%   53.21%           
===============================================
  Files                 131      131           
  Lines               12002    12002           
===============================================
  Hits                 6387     6387           
  Misses               5615     5615           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14d708...29a1412. Read the comment docs.

@mjcarroll mjcarroll merged commit fbfc382 into ign-rendering3 May 25, 2021
@mjcarroll mjcarroll deleted the release/3.5.0 branch May 25, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants