Fix compilation against Ogre 1.10.12 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
|
Not 100% sure, but I guess the CI failure is not related to this PR, as it appears also in #389 . |
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #390 +/- ##
===============================================
Coverage 53.34% 53.35%
===============================================
Files 131 131
Lines 12035 12035
===============================================
+ Hits 6420 6421 +1
+ Misses 5615 5614 -1
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
CI is not able to find Ogre https://build.osrfoundation.org/job/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/1745/console . @j-rivero do you mind to take a quick look ?
Otherwise LGTM
j-rivero
approved these changes
Oct 11, 2021
j-rivero
added a commit
to j-rivero/ign-rendering
that referenced
this pull request
Oct 12, 2021
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
iche033
added a commit
that referenced
this pull request
Oct 19, 2021
* ogre: Do not assume that ogre plugins have lib prefix on macOS (#454) Signed-off-by: Silvio <silvio@traversaro.it> * Fix compilation against Ogre 1.10.12 (#390) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Avoid symbol redefition to fix armel builds (#457) * Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Fix logic on warning for ogre versions different than 1.9.x (#465) * Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> * Fix context attributes of glXCreateContextAttribsARB. (#460) Signed-off-by: Hill Ma <hillma@google.com> Co-authored-by: Silvio Traversaro <silvio@traversaro.it> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Hill Ma <mahiuchun@users.noreply.github.com>
srmainwaring
pushed a commit
to srmainwaring/gz-rendering
that referenced
this pull request
Oct 21, 2021
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
WilliamLewww
pushed a commit
to WilliamLewww/ign-rendering
that referenced
this pull request
Dec 7, 2021
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #374
Summary
Port the patch from conda-forge/libignition-rendering4-feedstock@a5a4537 . To be honest I did not tested compilation against other 1.10.* releases, but for sure this fixes compilation against 1.10.12 .
Checklist
codecheckpassed (See contributing)