Non desired window opening alongside ignition GUI

[ahcorde]

🦟 Bug fix

Summary

Fix gazebosim/gz-gui#291

Requires a PR in ign-gui6 gazebosim/gz-gui#292

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[iche033]

I think this new SetWinID API is no longer needed because winId is now passed as one of the engine params in gazebosim/gz-gui#292?

[ahcorde]

I think this new SetWinID API is no longer needed because winId is now passed as one of the engine params in ignitionrobotics/ign-gui#292?

These changes are required because the params passed by ign-gui are parsed inside ign-rendering to offer the API to the different Render engines

[codecov]

Codecov Report

Merging #436 (4de11cb) into main (6d08ef3) will increase coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head 4de11cb differs from pull request most recent head c6e547c. Consider uploading reports for the commit c6e547c to get more accurate results

@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files         192      192           
  Lines       19549    19554    +5     
=======================================
+ Hits        10458    10461    +3     
- Misses       9091     9093    +2     

Impacted Files	Coverage Δ
ogre2/src/Ogre2RenderEngine.cc	79.56% <60.00%> (-0.25%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d08ef3...c6e547c. Read the comment docs.

[chapulina]

These changes are required because the params passed by ign-gui are parsed inside ign-rendering to offer the API to the different Render engines

I'm not sure I understand. Can you point out where SetWinId is used?

[matosinho]

Issue fixed here for me with this branch.

[matosinho]

Issue fixed here for me with this branch.

[ahcorde]

I'm not sure I understand. Can you point out where SetWinId is used?

The params variable is the same type in ign-gui and ign-rendering but both libraries need to keep it own copy.

[chapulina]

Works for me 👍