Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Header Migration : ign-rendering #618

Merged
merged 4 commits into from
May 9, 2022
Merged

ign -> gz Header Migration : ign-rendering #618

merged 4 commits into from
May 9, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented May 5, 2022 •
edited
Loading

See gazebo-tooling/release-tools#711

Note: I changed Ogre2IgnOgreRenderingMode -> Ogre2GzOgreRenderingMode. But the ignition redirection header is called Ogre2IgnOgreRenderingMode. I think that's fine, but I'm open to comments.

:(

image

@methylDragon methylDragon requested a review from iche033 as a code owner May 5, 2022 01:21
@methylDragon methylDragon marked this pull request as draft May 5, 2022 01:21
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 5, 2022
@methylDragon methylDragon mentioned this pull request May 5, 2022
Closed
@methylDragon methylDragon force-pushed the header_migration branch 2 times, most recently from f0bf4fd to 40ec9de Compare May 6, 2022 19:24
@codecov
Copy link

codecov bot commented May 6, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@24506d0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage        ?   80.00%           
=======================================
  Files           ?        1           
  Lines           ?       15           
  Branches        ?        0           
=======================================
  Hits            ?       12           
  Misses          ?        3           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24506d0...5c0254e. Read the comment docs.

@methylDragon methylDragon marked this pull request as ready for review May 6, 2022 19:50
chapulina
chapulina approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

image

include/ignition/rendering/detail/Export.hh Outdated Show resolved Hide resolved
ogre/include/ignition/rendering/ogre/detail/Export.hh Outdated Show resolved Hide resolved
ogre2/src/terrain/Terra/CMakeLists.txt Show resolved Hide resolved
@methylDragon
Move header files with git mv (#618)
2e464fe 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Create redirection aliases (#618)
bd6b316 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate sources in src, test, examples, and include (#618)
714be92 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate CMake files (#618)
5c0254e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
chapulina approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@methylDragon methylDragon merged commit ff16689 into main May 9, 2022
@methylDragon methylDragon deleted the header_migration branch May 9, 2022 18:06
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 11, 2022
methylDragon added a commit that referenced this pull request May 12, 2022
@methylDragon
Revert "Merge pull request #618 from gazebosim/header_migration"
101a980 
This reverts commit ff16689.
methylDragon added a commit that referenced this pull request May 13, 2022
@methylDragon
Revert "Merge pull request #618 from gazebosim/header_migration"
a85f88e 
This reverts commit ff16689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina