Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz File Move for IgnHlms #631

Merged
merged 1 commit into from
May 24, 2022
Merged

ign -> gz File Move for IgnHlms #631

merged 1 commit into from
May 24, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from iche033 as a code owner May 23, 2022 23:44
@methylDragon
Migrate IgnHlms to GzHlms (#631)
1a72c69 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon mentioned this pull request May 23, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 23, 2022
chapulina
chapulina approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

ogre2/include/gz/rendering/ogre2/Ogre2RenderEngine.hh
@@ -54,7 +54,7 @@ namespace ignition
//
// forward declaration
class Ogre2RenderEnginePrivate;
class Ogre2IgnHlmsSphericalClipMinDistance;
class Ogre2GzHlmsSphericalClipMinDistance;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this PR's fault, but I wonder how downstream applications are expected to use the Ogre2RenderEngine.hh header if the Ogre2IgnHlmsSphericalClipMinDistance header isn't installed.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 23, 2022
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

Merging #631 (d0b250c) into main (ff16689) will not change coverage.
The diff coverage is n/a.

❗ Current head d0b250c differs from pull request most recent head 1a72c69. Consider uploading reports for the commit 1a72c69 to get more accurate results

@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           1        1           
  Lines          15       15           
=======================================
  Hits           12       12           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff16689...1a72c69. Read the comment docs.

@methylDragon methylDragon merged commit 5832255 into main May 24, 2022
@methylDragon methylDragon deleted the migrate_ignhlms branch May 24, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina