Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address todo in Ogre2ParticleEmitter - override PreRender function #871

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 25, 2023

🦟 Bug fix

Summary

Address todo note about an ABI breaking change in Ogre2ParticleEmitter class.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #871 (c214a55) into main (54e6140) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head c214a55 differs from pull request most recent head 47c8aa4. Consider uploading reports for the commit 47c8aa4 to get more accurate results

@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   75.03%   75.02%   -0.02%     
==========================================
  Files         176      176              
  Lines       16830    16829       -1     
==========================================
- Hits        12629    12626       -3     
- Misses       4201     4203       +2     
Files Changed Coverage Δ
ogre2/src/Ogre2ParticleEmitter.cc 78.57% <100.00%> (-0.11%) ⬇️

... and 1 file with indirect coverage changes

@iche033 iche033 merged commit e22380f into main Jul 25, 2023
5 of 6 checks passed
@iche033 iche033 deleted the particle_emitter_todo branch July 25, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants