Merge ign-sensors3 ➡️ ign-sensors6 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ⬆️ 2.9.1 🏁 (#70) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Change IGN_DESIGNATION to GZ_DESIGNATION (#246) Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #252 +/- ##
=============================================
Coverage 72.16% 72.16%
=============================================
Files 34 34
Lines 3470 3470
=============================================
Hits 2504 2504
Misses 966 966 Continue to review full report at Codecov.
|
ahcorde
previously requested changes
Jul 29, 2022
There was a problem hiding this comment.
All camera Tests are failing on Jammy
16 - INTEGRATION_boundingbox_camera (SEGFAULT)
20 - INTEGRATION_depth_camera (SEGFAULT)
24 - INTEGRATION_gpu_lidar_sensor (SEGFAULT)
26 - INTEGRATION_rgbd_camera (SEGFAULT)
28 - INTEGRATION_segmentation_camera (SEGFAULT)
30 - INTEGRATION_thermal_camera (SEGFAULT)
All rendering tests have been failing on Jammy before this PR. |
iche033
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-sensors3➡️ign-sensors6Branch comparision: ign-sensors6...ign-sensors3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)