Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
  • Loading branch information
Crola1702 committed Jun 9, 2023
1 parent 837e78f commit 27ef368
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ else()
set (EXTRA_TEST_LIB_DEPS)
endif()

# We're disabling pybind11 by default on Windows because they
# don't have active CI on them for now.
set(skip_pybind11_default_value OFF)
if (MSVC)
set(skip_pybind11_default_value ON)
Expand Down Expand Up @@ -211,9 +213,9 @@ else()

if (${pybind11_FOUND})
message (STATUS "Searching for pybind11 - found version ${pybind11_VERSION}.")
else()
IGN_BUILD_WARNING("pybind11 is missing: Python interfaces are disabled.")
message (STATUS "Searching for pybind11 - not found.")
else()
IGN_BUILD_WARNING("pybind11 is missing: Python interfaces are disabled.")
message (STATUS "Searching for pybind11 - not found.")
endif()
endif()
endif()
Expand All @@ -237,7 +239,7 @@ add_subdirectory(examples)
#============================================================================
ign_create_packages()

if (pybind11_FOUND AND NOT SKIP_PYBIND11)
if (pybind11_FOUND)
add_subdirectory(python)
endif()
#============================================================================
Expand Down

0 comments on commit 27ef368

Please sign in to comment.