Move some plugins to ign-gui

[ahcorde]

I was checking some of the plugins that are currently in ign-gazebo but they don't have any gazebo dependency. I think we should move these plugins to ign-gui.

For example:

• video_recorder
• view_angle
• grid_config
• tape_measure (when this PR is in Emit more events from Scene3D gz-gui#213)

@scpeters @iche033 @mjcarroll thoughts?

[mjcarroll]

I'm in favor of moving whatever possible into ign-gui. 👍

[ahcorde]

what's the process of doing that ? should I need to deprecate something ? or is it just remove from ign-gazebo and move the plugin to ign-gui ?

[mjcarroll]

My opinion would be that we can move them in the next major release of both gui and gazebo without deprecation. Anybody depending on ign-gazebo would already be depending on ign-gui.

[scpeters]

I support moving plugins to ign-gui when possible

• grid_config
• tape_measure (when this PR is in ignitionrobotics/ign-gui#213)

these ones look straightforward to me

• video_recorder
• view_angle

these ones depend on ignition transport services /gui/view_angle and /gui/record_video:

• https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo5/src/gui/plugins/view_angle/ViewAngle.cc#L64
• https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo5/src/gui/plugins/video_recorder/VideoRecorder.cc#L71

I think the camera_video_recorder system and the view_angle service would have to be migrated to ignition::gui::Scene3D

[scpeters]

I know there are different names used for Scene3D in ign-gui and GzScene3D in ign-gazebo since the config files just look for shared libraries. So I expect we might need to use different names for the ign-gui version?

[chapulina]

Yes! These plugins should have never been added to ign-gazebo to begin with, we did that for expediency at first, but new plugins such as Screenshot have been added directly to ign-gui.

So I expect we might need to use different names for the ign-gui version?

Correct, we'd need to use different names if we want them to coexist. But @mjcarroll 's idea is interesting:

we can move them in the next major release of both gui and gazebo without deprecation.

Technically, Ignition GUI would just pick up the different library, so I think it could work. If we take this route, we should make sure we don't change any of the plugin arguments so users can transition seamlessly.

[ahcorde]

Fortress collection file is pointing to main in ign-gui and ign-gazebo. I start moving these two plugins from ign-gazebo to ign-gui:

• grid_config
• tape_measure

[ahcorde]

PRs

• Removed from ign-gazebo Removed and moved tape measure and grid config to ign-gui #870
• Added to ign-gui Moved tape measure and grid config from ign-gazebo to ign-gui gz-gui#236

[chapulina]

All plugins that could be trivially moved have been