-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit more events from Scene3D #213
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
I removed the tests that weren't working and ticketed #216. Opening this for review. It's worth reading the conversation on #209. The current approach to emitting events is necessary for some use cases, but adds unnecessary complexity for others. I think we could revisit the current architecture in a future release in favor of an |
There seems to be a problem with loading the ignition-rendering-ogre plugin from the Scene3D test if it links to that plugin. Making Scene3D_TEST.cc into an integration test works because it doesn't directly call any plugin methods. This also changes the linking for the Grid3D plugin to only link to the ignition-rendering core library target instead of the IGNITION-RENDERING_LIBRARIES variable which includes the ogre component library plugins. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
I've fixed the issue with loading the render engines documented in #216 and have merged those changes into this branch. I moved |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
I added a test for the
|
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #213 +/- ##
============================================
+ Coverage 59.55% 65.56% +6.00%
============================================
Files 23 23
Lines 2715 2817 +102
============================================
+ Hits 1617 1847 +230
+ Misses 1098 970 -128
Continue to review full report at Codecov.
|
I can try adding some more tests. Do you know how to create fake mouse clicks from a test? |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
I just noticed the windows build has been broken since 23c0578
|
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
I've added some expectations about the value of the |
test/integration/scene3d.cc
Outdated
std::cerr << "hoverToScene point[" | ||
<< hoverToScene->Point() << "]" << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this trace ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Release 3.5.1 (#195) Signed-off-by: Steve Peters <scpeters@openrobotics.org> * check_test_ran.py: remove grep/xsltproc (#203) We aren't using QTest anymore in ign-gui, so remove the parts of check_test_ran.py that translated QTest xml files into junit, since they don't work easily on Windows and aren't needed any longer. Fixes #198. Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Fixed material specular in scene3D (#218) Signed-off-by: ahcorde <ahcorde@gmail.com> * Remove tools/code_check and update codecov (#222) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Removed duplicated code with rendering::sceneFromFirstRenderEngine (#223) Signed-off-by: ahcorde <ahcorde@gmail.com> * Emit more events from Scene3D (#213) * Start porting events from ign-gazebo Signed-off-by: Louise Poubel <louise@openrobotics.org> * Remove test that fails due to #216 Signed-off-by: Louise Poubel <louise@openrobotics.org> * Move Scene3d_TEST.cc to test/integration There seems to be a problem with loading the ignition-rendering-ogre plugin from the Scene3D test if it links to that plugin. Making Scene3D_TEST.cc into an integration test works because it doesn't directly call any plugin methods. This also changes the linking for the Grid3D plugin to only link to the ignition-rendering core library target instead of the IGNITION-RENDERING_LIBRARIES variable which includes the ogre component library plugins. Signed-off-by: Steve Peters <scpeters@openrobotics.org> * process qt events to allow scene to initialize Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Add test helper to check event Signed-off-by: Louise Poubel <louise@openrobotics.org> * added more tests Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Move TestHelper code to .cc file, fix windows? Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Fix windows? Signed-off-by: ahcorde <ahcorde@gmail.com> * Fix windows? Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> * Expect values of Vector3 point in click events Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Remove debug message Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Remove unused variable Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: ahcorde <ahcorde@gmail.com> * Avoid grid3D crash (#227) Signed-off-by: ahcorde <ahcorde@gmail.com> * Confirmation dialog when closing main window (#225) * Adds confirmation dialog when closing window * Updates docs and extends test coverage. * Adds dialog_on_exit atribute to example .config Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com> * update codeowners (#232) Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * 🎈 3.6.0 (#233) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Bump required ign-rendering version to 4.8 (#234) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Franco Cipollone <53065142+francocipollone@users.noreply.github.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
🎉 New feature
Closes #209
Related to gazebosim/gz-rviz#70
Summary
This PR makes the 3D scene emit more events, such as clicks and hover, that can be used by other plugins. Most of the code here has been ported from ignition::gazebo::Scene3D.
I got stuck writing tests for it though, for some reason the render engine plugin is not properly loaded. I spent some time digging deep into
ign-plugin
with no luck. I'll leave this as draft until I can address this.Test it
I'd like to add an example plugin that makes use of these events, so others can use it as a pattern to copy for their needs.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸