Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_test_ran.py requires grep and xsltproc #198

Closed
traversaro opened this issue Mar 24, 2021 · 2 comments
Closed

check_test_ran.py requires grep and xsltproc #198

traversaro opened this issue Mar 24, 2021 · 2 comments
Assignees
@scpeters
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@traversaro
Copy link
Contributor

Desired behavior

The check_test_ran.py requires grep and xsltproc, that may not be present in some machine (especially Windows), leading to check_ test failures.

Implementation suggestion

It seems that other ignition projects use a different version of check_test_ran.py that does not use grep and xsltproc (see https://github.com/ignitionrobotics/ign-math/commits/ign-math6/tools/check_test_ran.py, grep and xsltproc usage removed in gazebosim/gz-math@69d881d#diff-2d6a060081b4c12efdbe4f12e846ead21821236e834f41885a04e41e884687c2 ). Could it make sense to use the same version here, or instead it is better to stick to the version that uses grep and xsltproc ?

Additional context

Related to conda-forge/libignition-gui-feedstock#2 .
@traversaro traversaro added the enhancement New feature or request label Mar 24, 2021
@traversaro traversaro mentioned this issue Mar 24, 2021
Merged
5 tasks
@scpeters
Copy link
Member

This is a leftover from osrf/gazebo, which uses the qtest_to_junit.xslt file to translate the xml output files produced by QTest into junit files that can be read by Jenkins. We removed this functionality from other ignition packages, as you noted, but I hadn't removed it here as I thought we were still using QTest. It turns out we stopped using it as of bitbucket pull request 70 (13d314e), so we can remove the grep and xsltproc portions from check_test_ran.py as well.

@chapulina chapulina added help wanted Extra attention is needed enhancement New feature or request and removed enhancement New feature or request labels Mar 29, 2021
@scpeters scpeters self-assigned this Mar 29, 2021
scpeters added a commit that referenced this issue Mar 29, 2021
@scpeters
check_test_ran.py: remove grep/xsltproc
bd6f2e2 
We aren't using QTest anymore in ign-gui, so remove
the parts of check_test_ran.py that translated QTest
xml files into junit, since they don't work easily
on Windows and aren't needed any longer.

Fixes #198.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this issue Mar 29, 2021
@scpeters
check_test_ran.py: remove grep/xsltproc
615d44b 
We aren't using QTest anymore in ign-gui, so remove
the parts of check_test_ran.py that translated QTest
xml files into junit, since they don't work easily
on Windows and aren't needed any longer.

Fixes #198.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 29, 2021
Merged
7 tasks
@scpeters
Copy link
Member

see #203

chapulina pushed a commit that referenced this issue Apr 5, 2021
@scpeters
check_test_ran.py: remove grep/xsltproc (#203)
064f815 
We aren't using QTest anymore in ign-gui, so remove
the parts of check_test_ran.py that translated QTest
xml files into junit, since they don't work easily
on Windows and aren't needed any longer.

Fixes #198.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Apr 29, 2021
Merged
8 tasks
chapulina added a commit that referenced this issue Jun 22, 2021
@chapulina @scpeters
@ahcorde @francocipollone @jennuine
3 ➡️ 4 (#234)
8e8f51c 
* Release 3.5.1 (#195)

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* check_test_ran.py: remove grep/xsltproc (#203)

We aren't using QTest anymore in ign-gui, so remove
the parts of check_test_ran.py that translated QTest
xml files into junit, since they don't work easily
on Windows and aren't needed any longer.

Fixes #198.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Fixed material specular in scene3D (#218)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Remove tools/code_check and update codecov (#222)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Removed duplicated code with rendering::sceneFromFirstRenderEngine (#223)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Emit more events from Scene3D (#213)

* Start porting events from ign-gazebo

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Remove test that fails due to #216

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Move Scene3d_TEST.cc to test/integration

There seems to be a problem with loading the ignition-rendering-ogre
plugin from the Scene3D test if it links to that plugin. Making
Scene3D_TEST.cc into an integration test works because it doesn't
directly call any plugin methods.

This also changes the linking for the Grid3D plugin to only link
to the ignition-rendering core library target instead of the
IGNITION-RENDERING_LIBRARIES variable which includes the ogre
component library plugins.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* process qt events to allow scene to initialize

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Add test helper to check event

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* added more tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Move TestHelper code to .cc file, fix windows?

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Fix windows?

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix windows?

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* Expect values of Vector3 point in click events

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Remove debug message

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Remove unused variable

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: ahcorde <ahcorde@gmail.com>

* Avoid grid3D crash (#227)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Confirmation dialog when closing main window (#225)

* Adds confirmation dialog when closing window
* Updates docs and extends test coverage.
* Adds dialog_on_exit atribute to example .config

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>

* update codeowners (#232)

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* 🎈 3.6.0 (#233)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Bump required ign-rendering version to 4.8 (#234)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Franco Cipollone <53065142+francocipollone@users.noreply.github.com>
Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scpeters scpeters

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@traversaro @scpeters @chapulina