Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.5.1 #195

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Bump to 3.5.1 #195

merged 4 commits into from
Mar 18, 2021

Conversation

scpeters
Copy link
Member

🎈 Release

Preparation for 3.5.1 release.

Comparison to 3.5.0: ignition-gui3_3.5.0...ign-gui3

The changes in #191 are needed by TRI Roads project. @chapulina do we need to wait for #194?

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from chapulina March 18, 2021 00:11
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #195 (ef5dc3a) into ign-gui3 (3794b8a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #195   +/-   ##
=========================================
  Coverage     59.03%   59.03%           
=========================================
  Files            23       23           
  Lines          2739     2739           
=========================================
  Hits           1617     1617           
  Misses         1122     1122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3794b8a...ef5dc3a. Read the comment docs.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters merged commit 01cc9e0 into ign-gui3 Mar 18, 2021
@scpeters scpeters deleted the bump_351 branch March 18, 2021 17:28
chapulina added a commit that referenced this pull request Jun 22, 2021
* Release 3.5.1 (#195)

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* check_test_ran.py: remove grep/xsltproc (#203)

We aren't using QTest anymore in ign-gui, so remove
the parts of check_test_ran.py that translated QTest
xml files into junit, since they don't work easily
on Windows and aren't needed any longer.

Fixes #198.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Fixed material specular in scene3D (#218)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Remove tools/code_check and update codecov (#222)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Removed duplicated code with rendering::sceneFromFirstRenderEngine (#223)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Emit more events from Scene3D (#213)

* Start porting events from ign-gazebo

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Remove test that fails due to #216

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Move Scene3d_TEST.cc to test/integration

There seems to be a problem with loading the ignition-rendering-ogre
plugin from the Scene3D test if it links to that plugin. Making
Scene3D_TEST.cc into an integration test works because it doesn't
directly call any plugin methods.

This also changes the linking for the Grid3D plugin to only link
to the ignition-rendering core library target instead of the
IGNITION-RENDERING_LIBRARIES variable which includes the ogre
component library plugins.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* process qt events to allow scene to initialize

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Add test helper to check event

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* added more tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Move TestHelper code to .cc file, fix windows?

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Fix windows?

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix windows?

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* Expect values of Vector3 point in click events

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Remove debug message

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Remove unused variable

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: ahcorde <ahcorde@gmail.com>

* Avoid grid3D crash (#227)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Confirmation dialog when closing main window (#225)

* Adds confirmation dialog when closing window
* Updates docs and extends test coverage.
* Adds dialog_on_exit atribute to example .config

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>

* update codeowners (#232)

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* 🎈 3.6.0 (#233)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Bump required ign-rendering version to 4.8 (#234)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Franco Cipollone <53065142+francocipollone@users.noreply.github.com>
Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants