Scene3D: port mesh material fixes from ign-gazebo #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in #137, the Scene3D plugin was forked for use in ign-gazebo, with the intention of consolidating back with the ign-gui plugin to reduce duplication. This ports some fixes for mesh material loading to ign-gui made in gazebosim/gz-sim@897ef65 as part of bitbucket PR 315. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #191 +/- ##
============================================
- Coverage 59.23% 59.03% -0.20%
============================================
Files 23 23
Lines 2730 2739 +9
============================================
Hits 1617 1617
- Misses 1113 1122 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Port fixes for material loading in the Scene3D plugin from ign-gazebo.
Summary
As noted in #137, the Scene3D plugin was forked for use in ign-gazebo, with the intention of consolidating back with the ign-gui plugin to reduce duplication. This ports some fixes for mesh material loading to ign-gui made in gazebosim/gz-sim@897ef65 as part of bitbucket PR 315 as well as some other fixes to more closely match the current code in ign-gazebo's SceneManager.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge