Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Export lights for collada world exporter #901

Closed
ddengster opened this issue Jul 2, 2021 · 0 comments · Fixed by gazebosim/gz-common#228 or #912
Closed

[Feature] Export lights for collada world exporter #901

ddengster opened this issue Jul 2, 2021 · 0 comments · Fixed by gazebosim/gz-common#228 or #912
Assignees
Labels
enhancement New feature or request

Comments

@ddengster
Copy link
Contributor

ddengster commented Jul 2, 2021

Desired behavior

Enable capabilities to export lights into the .dae format along with the collada world exporter.

Implementation suggestion

Iterate through ecm.foreach for each light and 'add' each light to the dae file.

Additional context

This helps ease the lightmapping process. By maintaining the consistency of lights between ignition and blender, the lighting artist need not tweak lights to sync to the correct positions; and the latest stage of modification will give the final light positions/orientations. This also means ensuring PR #895 exports the light's position/orientations correctly in sdf format.

I'll be working on this feature on this branch. Let me know if there's an alternative.

@ddengster ddengster added the enhancement New feature or request label Jul 2, 2021
@ddengster ddengster changed the title [Feature] Export light for collada world exporter [Feature] Export lights for collada world exporter Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant