Collada world exporter now exporting lights #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
8 tasks
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
ahcorde
requested changes
Jul 12, 2021
chapulina
added
the
needs upstream release
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
ahcorde
approved these changes
Jul 13, 2021
Signed-off-by: ddengster <ed.fan@osrfoundation.org>
chapulina
removed
the
needs upstream release
chapulina
suggested changes
Aug 3, 2021
…test Signed-off-by: ddengster <ed.fan@osrfoundation.org>
|
@osrf-jenkins retest this please |
|
@chapulina Friendly reminder |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ddengster ed.fan@osrfoundation.org
🎉 New feature
Closes #901
Upstream ign-common PR
Summary
Collada world exporter now exporting lights
As seen in ignition
As seen in blender
Test it
Run
./build/ignition-gazebo5/bin/INTEGRATION_collada_world_exporterChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge