Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DART deps to Focal #1005

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Conversation

playertr
Copy link
Contributor

@playertr playertr commented Aug 31, 2021

🦟 Bug fix

Fixes #1004

Summary

Within the Docker install_ign_deps.sh script, I updated DART dependencies from packages within the Bionic apt repositories to their Focal counterparts, at @chapulina 's suggestion from #1004 .

NOTE! : After making the changes, building ign_gazebo:base and ign_gazebo:nightly successfully completed. However, I have not been able to verify that the images function properly. I've been unsuccessfully debugging X forwarding to make glxgears or ign gazebo shapes.sdf work in the container with a GUI.

I'm opening this PR because I don't think it is related to my X11 bug, but I'd appreciate it if someone could verify that the created containers are correct.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@playertr playertr requested a review from chapulina as a code owner August 31, 2021 18:54
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 31, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Do you mind signing your commit for the DCO check?

For dealing with X issues, I recommend you take a look at https://github.com/adlarkin/ign-rocker. It was featured at this community meeting: https://www.youtube.com/watch?v=WcLj78PyrGk&list=PL6FI-gIL5jiGlch_uoSVNhCFaZb9eoj1J&index=3

@playertr
Copy link
Contributor Author

playertr commented Sep 1, 2021

Oops, I added a GPG key signature.

Rocker looks cool! I'll check out that video, which looks like it could supply some helpful context (I'm new to Docker). I assumed that the Docker image was intended to support OpenGL rendering, but it looks like it's meant to be a single node in a multi-container system. It looks like reading the Rocker docs could help me learn about how Docker and Ignition can work together.

@chapulina
Copy link
Contributor

Oops, I added a GPG key signature.

I don't see the signature on the commit. See the details on the DCO checker: https://github.com/ignitionrobotics/ign-gazebo/pull/1005/checks?check_run_id=3478863349

I assumed that the Docker image was intended to support OpenGL rendering

I believe that may still depend on your host's NVIDIA drivers. I won't be able to test our Docker instructions soon to see if they can be updated further. But let's continue the conversation on #1004

Signed-off-by: Tim Player <playert@oregonstate.edu>
@chapulina chapulina merged commit f5a457d into gazebosim:ign-gazebo5 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ign-gazebo5 Docker build fails; unable to locate package dart6-data
2 participants