-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MinimalScene by default #1014
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
85d84a6
to
e990ca9
Compare
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…nitionrobotics/ign-gazebo into chapulina/6/minimal_scene_def
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
9e675ab
to
44ffff4
Compare
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 with some minor nits
Codecov Report
@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
+ Coverage 63.47% 63.60% +0.13%
==========================================
Files 241 251 +10
Lines 19577 19614 +37
==========================================
+ Hits 12426 12476 +50
+ Misses 7151 7138 -13
Continue to review full report at Codecov.
|
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
🎉 New feature
Part of gazebosim/gz-gui#137
Summary
Ideally we'd deprecate
GzScene3D
on Fortress so we stop maintaining 2 scenes. For that to happen, we need to achieve feature parity withMinimalScene
. We need the following, and maybe more:It would also be good to get this in, so it's easier to configure the GUI and users don't have to repeat lots of plugins for the 3D scene:Going without it for nowTest it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸