Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use minimal scene in examples #1065

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Use minimal scene in examples #1065

merged 4 commits into from
Oct 1, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 28, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Use minimal scene in examples/worlds

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde
Use minimal scene in examples
bbdd92f 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 28, 2021
@ahcorde ahcorde requested a review from chapulina as a code owner September 28, 2021 12:01
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #1065 (57224d9) into main (5f2d974) will not change coverage.
The diff coverage is n/a.

❗ Current head 57224d9 differs from pull request most recent head 507f245. Consider uploading reports for the commit 507f245 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files         255      255           
  Lines       19994    19994           
=======================================
  Hits        12812    12812           
  Misses       7182     7182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2d974...507f245. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working labels Sep 28, 2021
@chapulina
merged from main
57224d9 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Remove more GzScene3D and flip default legacy behaviour
d19d40e 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
chapulina approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed some more instances in d19d40e, and also flipped the behaviour of the legacy flags so that plugins inserted from the menu work with MinimalScene by default.

Let's wait for full CI before merging.

@chapulina
fix test
507f245 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 4208c07 into main Oct 1, 2021
@chapulina chapulina deleted the ahcorde/examples/minimal_scene branch October 1, 2021 18:31
ahcorde added a commit that referenced this pull request Oct 12, 2021
@ahcorde @chapulina
Use minimal scene in examples (#1065)
c9eb0b6 
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@ahcorde ahcorde

Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @mjcarroll @chapulina