-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed sensor plugins #1104
Fixed sensor plugins #1104
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…ionrobotics/ign-gazebo into ahcorde/fix/sensor_plugins
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1104 +/- ##
============================================
Coverage 77.42% 77.43%
============================================
Files 222 222
Lines 12769 12797 +28
============================================
+ Hits 9887 9909 +22
- Misses 2882 2888 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! I'll leave it up to you whether to address the minor comments below
Signed-off-by: ahcorde <ahcorde@gmail.com>
* Fixed sensor plugins Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed compilation Signed-off-by: ahcorde <ahcorde@gmail.com> * Fix comment Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Related with this PR #1043
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge