Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sensor plugins #1104

Merged
merged 6 commits into from
Nov 5, 2021
Merged

Fixed sensor plugins #1104

merged 6 commits into from
Nov 5, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 13, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Related with this PR #1043

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina as a code owner October 13, 2021 21:47
@ahcorde ahcorde self-assigned this Oct 13, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1104 (df54565) into ign-gazebo3 (a76cea4) will increase coverage by 0.00%.
The diff coverage is 79.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3    #1104   +/-   ##
============================================
  Coverage        77.42%   77.43%           
============================================
  Files              222      222           
  Lines            12769    12797   +28     
============================================
+ Hits              9887     9909   +22     
- Misses            2882     2888    +6     
Impacted Files Coverage Δ
src/systems/logical_camera/LogicalCamera.cc 76.25% <77.77%> (-1.84%) ⬇️
src/systems/air_pressure/AirPressure.cc 73.97% <79.31%> (-1.79%) ⬇️
src/systems/altimeter/Altimeter.cc 74.66% <80.00%> (-1.81%) ⬇️
src/systems/magnetometer/Magnetometer.cc 71.60% <82.14%> (-1.37%) ⬇️
src/SimulationRunner.cc 94.49% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76cea4...df54565. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! I'll leave it up to you whether to address the minor comments below

src/systems/air_pressure/AirPressure.cc Outdated Show resolved Hide resolved
@ahcorde ahcorde merged commit c0ad543 into ign-gazebo3 Nov 5, 2021
@ahcorde ahcorde deleted the ahcorde/fix/sensor_plugins branch November 5, 2021 14:23
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
* Fixed sensor plugins

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed compilation

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fix comment

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
chapulina added a commit that referenced this pull request Dec 22, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants