Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 ➡️ 7 (up to 7901903) #1380

Closed
wants to merge 26 commits into from
Closed

6 ➡️ 7 (up to 7901903) #1380

wants to merge 26 commits into from

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 23 commits December 22, 2021 10:46
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…el retarget) (#1314)

In the event a user enters the wrong name for a certain joint, the JointPositionController system will silently fail. This PR adds a simple error message that tells the user that the joint was not found.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* load and run visual plugins on gui end

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* scene update event emitted on both server and gui side

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* shader param update working

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* sim time, constants, full example working

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* add integration test

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* code cleanup

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* more code cleanup

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* style fixes and add some comments

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* review changes

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* require display for shader param test

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* style and comment

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* limit thrust cmd

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* check and error when max < min

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was some weird indentation going on in the `Link.hh` header file. This PR fixes it.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
This PR adds a Link::SetLinearVelocity() method. I foresee this method being useful for testing behaviour of systems like the hydrodynamics or liftDrag plugin which are dependent on velocity for their output forces.

Signed-off-by: Arjo Chakravarty arjo@openrobotics.org
updates the ShaderParam system with the ability to parse texture params and pass them to custom shaders

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* New trajectory follower system

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* Update changelog
* Bump to 6.5.0

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from mjcarroll March 9, 2022 21:03
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 9, 2022
@chapulina chapulina mentioned this pull request Mar 9, 2022
@chapulina chapulina mentioned this pull request Mar 9, 2022
8 tasks
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1380 (bf857e2) into main (faaa3ec) will decrease coverage by 0.18%.
The diff coverage is 47.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
- Coverage   62.32%   62.13%   -0.19%     
==========================================
  Files         278      277       -1     
  Lines       23242    23276      +34     
==========================================
- Hits        14485    14462      -23     
- Misses       8757     8814      +57     
Impacted Files Coverage Δ
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
...clude/ignition/gazebo/components/CenterOfVolume.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <ø> (ø)
include/ignition/gazebo/rendering/RenderUtil.hh 100.00% <ø> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
src/gui/GuiEvents.cc 44.44% <0.00%> (-12.70%) ⬇️
src/gui/GuiRunner.hh 100.00% <ø> (ø)
src/gui/plugins/scene_manager/GzSceneManager.cc 19.17% <0.00%> (-8.28%) ⬇️
...int_position_controller/JointPositionController.cc 71.85% <0.00%> (-2.20%) ⬇️
include/ignition/gazebo/components/Visual.hh 12.50% <6.66%> (-87.50%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c84e1c...bf857e2. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Mar 10, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

#1367 got in first, and I opened #1382 to fix the trajectory follower.

@chapulina chapulina closed this Mar 10, 2022
@chapulina chapulina deleted the chapulina/6_to_7_partial branch March 10, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants