Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new RFComms system #1428

Merged
merged 71 commits into from
Apr 14, 2022
Merged

Adds new RFComms system #1428

merged 71 commits into from
Apr 14, 2022

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Apr 5, 2022

🎉 New feature

Requires

Summary

This PR adds a radio frequency comms model atop comms infrastructure created in #1416.

Test it

  • Run the tests.
  • Run the example:
  1. Launch Gazebo:
ign gazebo -v 4 <your_ws>/src/ign-gazebo/examples/worlds/rf_comms.sdf
  1. Launch a subscriber:
ign topic -e -t addr2/rx
  1. Launch a publisher:
cd <your_ws>/src/ign-gazebo/examples/standalone/comms
mkdir build && cd build
cmake ..
make
./publisher addr2

You should observe messages on the subscriber terminal.

CC @arjo129

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

caguero and others added 30 commits March 2, 2022 20:21
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
caguero and others added 4 commits April 12, 2022 17:15
Signed-off-by: Carlos Aguero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
@chapulina chapulina mentioned this pull request Apr 13, 2022
7 tasks
caguero and others added 11 commits April 13, 2022 09:10
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@iche033 iche033 mentioned this pull request Apr 13, 2022
8 tasks
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Base automatically changed from comms to ign-gazebo6 April 13, 2022 19:59
iche033 added 3 commits April 13, 2022 13:04
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Copy link
Contributor

iche033 commented Apr 14, 2022

ok I think the build issues and warnings are resolved. Homebrew, windows, and ubuntu CI builds look fine now. Test failures are unrelated.

@caguero caguero merged commit 528fb63 into ign-gazebo6 Apr 14, 2022
@caguero caguero deleted the caguero/wireless_comms branch April 14, 2022 08:06
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants