Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 ➡️ 6 #1438

Merged
merged 2 commits into from
Apr 13, 2022
Merged

3 ➡️ 6 #1438

merged 2 commits into from
Apr 13, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

j-rivero and others added 2 commits April 8, 2022 18:10
@j-rivero
Use versioned svg file (#1430)
97a87c3 
To avoid conflicts between different major versions, add the major version to the svg filename.
@chapulina
3 ➡️ 6
641946f 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested review from j-rivero and scpeters April 12, 2022 17:57
@chapulina chapulina mentioned this pull request Apr 12, 2022
Merged
7 tasks
@chapulina chapulina mentioned this pull request Apr 12, 2022
Merged
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #1438 (641946f) into ign-gazebo6 (e3b5964) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gazebo6    #1438   +/-   ##
============================================
  Coverage        63.49%   63.49%           
============================================
  Files              307      307           
  Lines            24776    24776           
============================================
  Hits             15731    15731           
  Misses            9045     9045

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b5964...641946f. Read the comment docs.

@chapulina chapulina merged commit b825c27 into ign-gazebo6 Apr 13, 2022
@chapulina chapulina deleted the chapulina/3_to_6 branch April 13, 2022 01:00
@chapulina chapulina mentioned this pull request Jun 1, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlarkin adlarkin adlarkin approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

@scpeters scpeters Awaiting requested review from scpeters

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chapulina @mjcarroll @adlarkin @j-rivero