Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Header Migration : gz-sim #1477

Merged
merged 5 commits into from
May 17, 2022
Merged

ign -> gz Header Migration : gz-sim #1477

merged 5 commits into from
May 17, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented May 9, 2022 •
edited
Loading

@methylDragon methylDragon requested a review from chapulina as a code owner May 9, 2022 22:04
@methylDragon methylDragon marked this pull request as draft May 9, 2022 22:04
@methylDragon methylDragon force-pushed the header_migration branch 7 times, most recently from e5eedbe to c3bc5bd Compare May 9, 2022 22:19
@chapulina chapulina added ign to gz Renaming Ignition to Gazebo. 🌱 garden Ignition Garden labels May 10, 2022
@methylDragon methylDragon force-pushed the header_migration branch 17 times, most recently from a9da760 to 068a16a Compare May 11, 2022 23:40
methylDragon added a commit that referenced this pull request May 16, 2022
@methylDragon
Migrate CMake files (#1477)
5645d63 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@scpeters scpeters mentioned this pull request May 16, 2022
Merged
8 tasks
methylDragon added a commit that referenced this pull request May 16, 2022
@methylDragon
Create redirection aliases (#1477)
146d92f 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 16, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#1477)
1169f7a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 16, 2022
@methylDragon
Migrate CMake files (#1477)
c98fd21 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon changed the title ign -> gz Header Migration : ign-gazebo ign -> gz Header Migration : gz-sim May 16, 2022
@methylDragon
Move header files with git mv (#1477)
b8f6ef6 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Create redirection aliases (#1477)
1469bbb 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate sources in src, test, examples, and include (#1477)
bf52da5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate CMake files (#1477)
730b7cf 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina added a commit that referenced this pull request May 16, 2022
@chapulina
Update test log for gz components (#1477)
70dc816 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
chapulina approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew! LGTM if CI comes back without new test failures 🚀

@chapulina
Update test log for gz components (#1477)
1774cce 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented May 17, 2022 •
edited
Loading

Codecov Report

Merging #1477 (1774cce) into main (9370793) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1477   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files          44       44           
  Lines        2356     2356           
=======================================
  Hits          825      825           
  Misses       1531     1531
Impacted Files Coverage Δ
src/gui/plugins/modules/moc_EntityContextMenu.cpp 23.07% <0.00%> (ø)
...ntity_context_menu/qrc_EntityContextMenuPlugin.cpp 100.00% <0.00%> (ø)
include/ignition/gazebo/test_config.hh
..._/__/include/ignition/gazebo/gui/moc_GuiSystem.cpp
include/gz/sim/test_config.hh 100.00% <0.00%> (ø)
src/gui/__/__/include/gz/sim/gui/moc_GuiSystem.cpp 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9370793...1774cce. Read the comment docs.

chapulina
chapulina suggested changes May 17, 2022
View reviewed changes
test/benchmark/CMakeLists.txt
@@ -1,8 +1,8 @@
set(TEST_TYPE "BENCHMARK")

include(IgnBenchmark OPTIONAL RESULT_VARIABLE IgnBenchmark_FOUND)
include(GzBenchmark OPTIONAL RESULT_VARIABLE GzBenchmark_FOUND)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh it looks like this is causing a warning

CMake Warning at /usr/share/cmake/ignition-cmake3/cmake3/IgnBenchmark.cmake:69 (find_package):
  By not providing "Findbenchmark.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "benchmark", but CMake did not find one.

  Could not find a package configuration file provided by "benchmark" with
  any of the following names:

    benchmarkConfig.cmake
    benchmark-config.cmake

  Add the installation prefix of "benchmark" to CMAKE_PREFIX_PATH or set
  "benchmark_DIR" to a directory containing one of the above files.  If
  "benchmark" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  test/benchmark/CMakeLists.txt:13 (ign_add_benchmarks)

Maybe we can leave it for later?

chapulina
chapulina approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, the CI failures aren't new

@chapulina chapulina merged commit ea1f377 into main May 17, 2022
@chapulina chapulina deleted the header_migration branch May 17, 2022 20:16
chapulina pushed a commit that referenced this pull request May 17, 2022
@methylDragon @chapulina
Move header files with git mv (#1477)
5f9707e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina pushed a commit that referenced this pull request May 17, 2022
@methylDragon @chapulina
Create redirection aliases (#1477)
411dca0 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina pushed a commit that referenced this pull request May 17, 2022
@methylDragon @chapulina
Migrate sources in src, test, examples, and include (#1477)
29b99c6 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina pushed a commit that referenced this pull request May 17, 2022
@methylDragon @chapulina
Migrate CMake files (#1477)
ddeecfe 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 18, 2022
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @chapulina