New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick start dialog #1536

Merged

chapulina merged 92 commits into ign-gazebo3 from quick_setup_menu

Aug 2, 2022

Contributor

mayman99 commented Jun 14, 2022 •

edited

Loading

🎉 New feature

depends on ign-gui418

Closes #1252

Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Mohamad added 10 commits

May 7, 2022 11:11


          basic quick setup layput added

0f926c3

Signed-off-by: Mohamad <mohamad@openrobotics.org>

wip

a8a2fce

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          add pre mainwindow window

d87546f

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          subscribe to starting world before starting the server

6761c5d

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          remove thumbunails

e945865

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          add create QuickSetup menu to GUI process

56e1f8d

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          clean up

75792b2

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          clean up

24c3e00

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          get worlds path using systems path

f0395f3

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          parse config for showing quick setup menu

85ebe81

Signed-off-by: Mohamad <mohamad@openrobotics.org>

chapulina added 🏰 citadel OOBE 📦✨ labels

Mohamad added 2 commits

June 15, 2022 12:22


          implment skip button

34aa9d2

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          revert quick setup breaking changes

a50a451

Signed-off-by: Mohamad <mohamad@openrobotics.org>

chapulina added the needs upstream release label

chapulina suggested changes

View reviewed changes

Contributor

chapulina left a comment

Did a high-level initial review, with some suggestions

src/gui/CMakeLists.txt Outdated Show resolved Hide resolved

src/ign.cc Outdated Show resolved Hide resolved

src/ign.cc Outdated Show resolved Hide resolved

src/ign.cc Outdated Show resolved Hide resolved

src/ign.cc Outdated Show resolved Hide resolved

src/gui/resources/QuickSetup.qml Outdated Show resolved Hide resolved

src/gui/Gui.cc Outdated Show resolved Hide resolved

src/gui/Gui.cc Outdated Show resolved Hide resolved

src/gui/resources/QuickSetup.qml Outdated Show resolved Hide resolved

src/ign.cc Outdated Show resolved Hide resolved

chapulina reviewed

View reviewed changes

src/gui/QuickSetup.hh Outdated Show resolved Hide resolved

Mohamad added 10 commits

June 16, 2022 10:52


          unsbscribe to starting world after msg is received

a9245d3

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          implment close window

ec82545

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          update runServer and runGui functions to handle a quick start menu

3486a5b

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          fix wait gui wrong condition

66e3058

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          read config before opening quick start menu

d8d37b9

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          revert quick setup option until pushing changes to ign-gui

3182f13

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          read config value for showing quick start window

6836a25

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          quick start menu desgin in progress

e860d37

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          add thumbunails for fuel worlds

f7836dc

Signed-off-by: Mohamad <mohamad@openrobotics.org>


          quick setup menu, loading fuel worlds

789296d

Signed-off-by: Mohamad <mohamad@openrobotics.org>

mayman99 self-assigned this

Contributor

chapulina commented Aug 1, 2022

I couldn't reproduce it thinking

I can try again soon. Did you try deleting ~/.ignition/gazebo/gui.config, then opening Gazebo and choosing the empty world?

Contributor Author

mayman99 commented Aug 1, 2022

I couldn't reproduce it thinking

I can try again soon. Did you try deleting ~/.ignition/gazebo/gui.config, then opening Gazebo and choosing the empty world?

I see, I could reproduce it when the gui.config is deleted 👍

chapulina and others added 5 commits

August 1, 2022 21:45


          Keep GUI config logic local

13ad82b

Signed-off-by: Louise Poubel <louise@openrobotics.org>


          Private launchQuickStart function

87198dc

Signed-off-by: Louise Poubel <louise@openrobotics.org>


          Move quick start logic into createGui

c35849b

Signed-off-by: Louise Poubel <louise@openrobotics.org>


          Handle config files passed by the CLI

a9c3382

Signed-off-by: Louise Poubel <louise@openrobotics.org>


          codecheck

a322cf5

Signed-off-by: Mohamad <mohamad@openrobotics.org>

mayman99 commented

View reviewed changes

src/gui/Gui.cc Show resolved Hide resolved

Contributor Author

mayman99 commented Aug 2, 2022

Thanks for the quick fix!, I went through the changes and it lgtm


          cloean up

34f2031

Signed-off-by: Louise Poubel <louise@openrobotics.org>

chapulina mentioned this pull request

Dialog read attribute: don't create a file gazebosim/gz-gui#450

Merged

8 tasks

chapulina added the needs upstream release label

chapulina mentioned this pull request

🎈 3.11.0 gazebosim/gz-gui#451

Merged

7 tasks

Contributor Author

mayman99 commented Aug 2, 2022

did a quick test run and nothing seems to be broken


          Add test, require GUI 3.11

bf32363

Signed-off-by: Louise Poubel <louise@openrobotics.org>

chapulina removed the needs upstream release label

chapulina approved these changes

View reviewed changes

Contributor

chapulina left a comment

This is ready to go! 🚀 I added an automated test and also checked these scenarios manually:

Loading ign gazebo after rm -rf ~/.ignition/gazebo/
Choosing not to show again updates ~/.ignition/gazebo/gui.config and works the next time simulation is open
Choosing Fuel worlds (all 5 work)
Choosing installed worlds
Choosing the empty world
Passing a custom --gui-config
- Checked that its show_again value is read and updated correctly
- That config is used instead of the one in the chosen file
Ctrl+C on the terminal with the quick start open doesn't load the main window
Closing the quick start dialog loads the blank world
Searching for worlds


          Remove unused import that doesn't work on Bionic

b1816c5

Signed-off-by: Louise Poubel <louise@openrobotics.org>

mayman99 commented

View reviewed changes

src/gui/Gui_TEST.cc

+                  EXPECT_TRUE(handler->ShowAgain());
+                  handler->SetStartingWorld("banana");
+                  EXPECT_EQ("banana", handler->StartingWorld());

Contributor Author

mayman99 Aug 2, 2022 •

edited

Loading

🍌 🍌
test looks very good 👍


          Restore ABI

a60b984

Signed-off-by: Louise Poubel <louise@openrobotics.org>

chapulina merged commit 2edbf56 into ign-gazebo3

chapulina deleted the quick_setup_menu branch

August 2, 2022 22:55

chapulina mentioned this pull request

Quick start dialog #1252

Closed

Contributor

chapulina commented Aug 3, 2022

I made a change on bf32363 to improve the tests, and that actually broke usage 🤦🏽‍♀️ Looking into it.

chapulina mentioned this pull request

Fix loading worlds from CLI #1627

Merged

8 tasks

Contributor

chapulina commented Aug 3, 2022

Here's the fix: Fix loading worlds from CLI #1627

chapulina mentioned this pull request

Fix Windows and Doxygen #1643

Merged

8 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel enhancement OOBE 📦✨