Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper function to get an entity from an entity message #1595

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

The Entity message has some documentation explaining how the message is meant to be used, but we don't have a helper function implementing that, leaving it up to plugin developers to parse the message as they see fit.

Over time, we've accumulated a couple of different implementations for the message parsing, and it would be good to standardize it in a single place. On ign-gazebo6, there are a couple of implementations in the UserCommands system:

The implementation here is a combination of the 2 above, which matches the description of the message.

Test it

See the added tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added 🏰 citadel Ignition Citadel needs upstream release Blocked by a release of an upstream library MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim labels Jul 15, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
src/Util.cc Outdated Show resolved Hide resolved
chapulina and others added 2 commits July 15, 2022 14:15
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1595 (c2b9656) into ign-gazebo3 (c565398) will increase coverage by 0.04%.
The diff coverage is 97.36%.

❗ Current head c2b9656 differs from pull request most recent head 57c9381. Consider uploading reports for the commit 57c9381 to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo3    #1595      +/-   ##
===============================================
+ Coverage        77.76%   77.81%   +0.04%     
===============================================
  Files              250      250              
  Lines            14447    14465      +18     
===============================================
+ Hits             11235    11256      +21     
+ Misses            3212     3209       -3     
Impacted Files Coverage Δ
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
src/Util.cc 93.97% <97.29%> (+0.57%) ⬆️
src/systems/user_commands/UserCommands.cc 82.00% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c565398...57c9381. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 4585958 into ign-gazebo3 Jul 19, 2022
@chapulina chapulina deleted the chapulina/3/entity_from_msg branch July 19, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants