-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper function to get an entity from an entity message #1595
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1595 +/- ##
===============================================
+ Coverage 77.76% 77.81% +0.04%
===============================================
Files 250 250
Lines 14447 14465 +18
===============================================
+ Hits 11235 11256 +21
+ Misses 3212 3209 -3
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
🎉 New feature
Summary
The
Entity
message has some documentation explaining how the message is meant to be used, but we don't have a helper function implementing that, leaving it up to plugin developers to parse the message as they see fit.Over time, we've accumulated a couple of different implementations for the message parsing, and it would be good to standardize it in a single place. On
ign-gazebo6
, there are a couple of implementations in theUserCommands
system:The implementation here is a combination of the 2 above, which matches the description of the message.
Test it
See the added tests.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸