Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition -> Gazebo #1596

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Ignition -> Gazebo #1596

merged 4 commits into from
Jul 15, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Part of:

Summary

Updated links and naming

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine added the QA Quality assurance. label Jul 15, 2022
@jennuine jennuine requested a review from chapulina as a code owner July 15, 2022 15:47
@jennuine jennuine self-assigned this Jul 15, 2022
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Jul 15, 2022
README.md Outdated
[![Discourse topics](https://img.shields.io/discourse/https/community.gazebosim.org/topics.svg)](https://community.gazebosim.org)
[![Hex.pm](https://img.shields.io/hexpm/l/plug.svg)](https://www.apache.org/licenses/LICENSE-2.0)

Build | Status
-- | --
Test coverage | [![codecov](https://codecov.io/gh/ignitionrobotics/ign-gazebo/branch/ign-gazebo3/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/ign-gazebo)
Test coverage | [![codecov](https://codecov.io/gh/gazebosim/gz-sim/branch/ign-gazebo3/graph/badge.svg)](https://codecov.io/gh/gazebosim/gz-sim/branch/ign-gazebo3)
Ubuntu Bionic | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_gazebo-ci-ign-gazebo3-bionic-amd64)](https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo3-bionic-amd64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah while at it, can we change this to Focal? Bionic isn't working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, should I do this for all the other libs too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Show resolved Hide resolved
jennuine added 2 commits July 15, 2022 09:45
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
…/ign-gazebo into jennuine/readme_updates

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1596 (9eb9faa) into ign-gazebo3 (33a0fce) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-gazebo3    #1596      +/-   ##
===============================================
- Coverage        77.76%   77.72%   -0.05%     
===============================================
  Files              250      250              
  Lines            14447    14447              
===============================================
- Hits             11235    11229       -6     
- Misses            3212     3218       +6     
Impacted Files Coverage Δ
src/SimulationRunner.cc 93.45% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a0fce...9eb9faa. Read the comment docs.

@chapulina chapulina merged commit 6d3eac2 into ign-gazebo3 Jul 15, 2022
@chapulina chapulina deleted the jennuine/readme_updates branch July 15, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel QA Quality assurance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants