Fix compilation of scene broadcaster test #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails to compile with the latest version of protobuf, which is currently available on macOS. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1599 +/- ##
===============================================
+ Coverage 77.72% 77.76% +0.04%
===============================================
Files 250 250
Lines 14447 14447
===============================================
+ Hits 11229 11235 +6
+ Misses 3218 3212 -6
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Jul 19, 2022
8 tasks
scpeters
added a commit
that referenced
this pull request
Jul 19, 2022
This test fails to compile with the latest version of protobuf, which is currently available on macOS. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
scpeters
added a commit
that referenced
this pull request
Jul 19, 2022
This test fails to compile with the latest version of protobuf, which is currently available on macOS. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
scpeters
added a commit
that referenced
this pull request
Jul 19, 2022
This test fails to compile with the latest version of protobuf, which is currently available on macOS. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jul 19, 2022
This test fails to compile with the latest version of protobuf, which is currently available on macOS. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jul 19, 2022
This test fails to compile with the latest version of protobuf, which is currently available on macOS. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes build on macOS with latest version of protobuf
Summary
This test fails to compile with the latest version of protobuf, which is currently available on macOS. Both
ign-gazebo6andign-gazebo3fail in the same way.A protobuf iterator no longer implicitly converts to
bool, so compare to the end iterator instead.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.