Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rendering, sensors and gui dependencies to 8 #1837

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 10, 2022

Bumped to use new Harmonic dependencies

gazebo-tooling/release-tools#853

marked draft while we wait for gui8 and sensors8 nightly debs to be ready
Update: Builds are working. Ready for review

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 marked this pull request as draft December 10, 2022 04:36
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1837 (c3d79e2) into main (5fe83a3) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
- Coverage   64.49%   64.46%   -0.03%     
==========================================
  Files         341      341              
  Lines       27098    27098              
==========================================
- Hits        17477    17469       -8     
- Misses       9621     9629       +8     
Impacted Files Coverage Δ
src/rendering/RenderUtil.cc 39.56% <ø> (ø)
src/systems/thruster/Thruster.cc 85.78% <0.00%> (-4.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Copy link
Contributor Author

iche033 commented Dec 14, 2022

@osrf-jenkins run tests please

@iche033 iche033 marked this pull request as ready for review December 14, 2022 04:35
@iche033
Copy link
Contributor Author

iche033 commented Dec 14, 2022

This PR is ready. Not sure why the jenksins build statuses are not updating but the latest CI builds are working with unrelated test failures:

https://build.osrfoundation.org/job/ign_gazebo-pr-win/5362 - 2 tests failure.
https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/9627/ - green
https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/10021/ - 1 test failure

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 merged commit ba46be3 into main Dec 15, 2022
@iche033 iche033 deleted the bump_harmonic_dep branch December 15, 2022 18:16
@iche033 iche033 added the 🎵 harmonic Gazebo Harmonic label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants