Update for new message generation and iwyu

[mjcarroll]

This moves the private_msgs proto files into their own directory to be used with gazebosim/gz-msgs#368

It also updates many files to actually include the messages they use.

[mjcarroll]

This isn't going to pass CI until we get one nightly turnover on msgs. @azeey what do you want to do?

[azeey]

This isn't going to pass CI until we get one nightly turnover on msgs. @azeey what do you want to do?

I manually triggered the build https://build.osrfoundation.org/job/gz-msgs10-debbuilder/446/, but the release package needs to be updated. See gazebo-release/gz-msgs10-release#7

[azeey]

@osrf-jenkins run tests please

[mjcarroll]

 /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libgz-transport13.so.13.0.0~pre1: undefined reference to `gz::msgs::v10::ToString[abi:cxx11](gz::msgs::Discovery_Type const&)'
  /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libgz-fuel_tools9.so.9.0.0: undefined reference to `gz::msgs::v10::ConvertFuelMetadata(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, gz::msgs::FuelMetadata&)'
  /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libgz-fuel_tools9.so.9.0.0: undefined reference to `gz::msgs::v10::ConvertFuelMetadata(gz::msgs::FuelMetadata const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&)'

Since we moved symbols around, we probably need intermediate nightlies to run as well. I will go ahead and trigger them now.

[azeey]

 /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libgz-transport13.so.13.0.0~pre1: undefined reference to `gz::msgs::v10::ToString[abi:cxx11](gz::msgs::Discovery_Type const&)'
  /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libgz-fuel_tools9.so.9.0.0: undefined reference to `gz::msgs::v10::ConvertFuelMetadata(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, gz::msgs::FuelMetadata&)'
  /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libgz-fuel_tools9.so.9.0.0: undefined reference to `gz::msgs::v10::ConvertFuelMetadata(gz::msgs::FuelMetadata const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&)'

Since we moved symbols around, we probably need intermediate nightlies to run as well. I will go ahead and trigger them now.

Just finished doing that.

@osrf-jenkins run tests please

[azeey]

Windows is failing to build

 Failed to execute protoc compiler: Command '['C:/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe', '--proto_path=C:/J/workspace/ign_gazebo-pr-win/ws/gz-sim/proto', '--descriptor_set_in=C:/J/workspace/ign_gazebo-pr-win/ws/install/gz-msgs10/share/gz/protos/gz-msgs10.gz_desc', '--plugin=protoc-gen-gzmsgs=C:/J/workspace/ign_gazebo-pr-win/ws/install/gz-msgs10//bin/gz-msgs10_protoc_plugin', '--cpp_out=dllexport_decl=GZ_MSGS_VISIBLE:C:/J/workspace/ign_gazebo-pr-win/ws/build/gz-sim8/gz-sim8-msgs_genmsg', '--gzmsgs_out=C:/J/workspace/ign_gazebo-pr-win/ws/build/gz-sim8/gz-sim8-msgs_genmsg', '--python_out=C:/J/workspace/ign_gazebo-pr-win/ws/build/gz-sim8/gz-sim8-msgs_genmsg/python/', 'C:/J/workspace/ign_gazebo-pr-win/ws/gz-sim/proto/gz/sim/private_msgs/peer_control.proto']' returned non-zero exit status 1.

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\J\workspace\ign_gazebo-pr-win\ws\build\gz-sim8\CMakeFiles\db8da3a23e2d11963041e207edd372b4\peer_control.pb.h.rule;C:\J\workspace\ign_gazebo-pr-win\ws\build\gz-sim8\CMakeFiles\db8da3a23e2d11963041e207edd372b4\peer_info.pb.h.rule;C:\J\workspace\ign_gazebo-pr-win\ws\build\gz-sim8\CMakeFiles\db8da3a23e2d11963041e207edd372b4\performer_affinity.pb.h.rule;C:\J\workspace\ign_gazebo-pr-win\ws\build\gz-sim8\CMakeFiles\db8da3a23e2d11963041e207edd372b4\simulation_step.pb.h.rule;C:\J\workspace\ign_gazebo-pr-win\ws\build\gz-sim8\CMakeFiles\db8da3a23e2d11963041e207edd372b4\MessageTypes.hh.rule;C:\J\workspace\ign_gazebo-pr-win\ws\build\gz-sim8\CMakeFiles\2ecabf52089c5108f2d458bd9c618598\gz-sim8-msgs.gz_desc.rule' exited with code -1. [C:\J\workspace\ign_gazebo-pr-win\ws\build\gz-sim8\proto\gz-sim8-msgs.vcxproj]

[azeey]

Rerunning Jenkins Jammy job to see if the failures are flaky:

[mjcarroll]

Yeah, those tests are checking for specific output and it looks like we are getting some bonus protobuf errors, looking into it.

[azeey]

@osrf-jenkins run tests please

[azeey]

UserCommandsTest.PoseVector is failing on both Linux and macOS. @mjcarroll can you take a look?

[mjcarroll]

UserCommandsTest.PoseVector is failing on both Linux and macOS. @mjcarroll can you take a look?

Yep

[azeey]

The macOS bottle build is taking a long time to build. Going forward with this without macOS.

@osrf-jenkins run tests please

[scpeters]

@osrf-jenkins run tests please

[azeey]

There's a build error on windows https://build.osrfoundation.org/job/ign_gazebo-pr-win/6095/

[scpeters]

https://build.osrfoundation.org/job/gz_sim-ci-pr_any-jammy-amd64/ is not being started on the most recent commits

[azeey]

Merging this and #2100 even though there's a build error on windows to unblock other PRs. We'll hopefully have the windows fix later today.