Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport collision bitmask changes #221

Closed
wants to merge 2 commits into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 24, 2020

backport of pull request #160

Signed-off-by: Ian Chen ichen@osrfoundation.org

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested review from azeey and chapulina as code owners June 24, 2020 18:32
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 24, 2020
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #221 into ign-gazebo3 will increase coverage by 0.18%.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #221      +/-   ##
===============================================
+ Coverage        65.14%   65.33%   +0.18%     
===============================================
  Files              127      127              
  Lines             6303     6311       +8     
===============================================
+ Hits              4106     4123      +17     
+ Misses            2197     2188       -9     
Impacted Files Coverage Δ
src/systems/physics/Physics.cc 33.84% <55.55%> (+0.27%) ⬆️
src/systems/physics/Physics.hh 100.00% <100.00%> (+9.09%) ⬆️
src/SimulationRunner.cc 87.54% <0.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aef19...d03eeb8. Read the comment docs.

@iche033
Copy link
Contributor Author

iche033 commented Jun 24, 2020

replaced by #223 which uses cherry-picking instead of creating a new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant