Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow/Wind sensor #2256

Open
wants to merge 7 commits into
base: gz-sim7
Choose a base branch
from
Open

Conversation

henrykotze
Copy link

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

This adds an airflow sensor. These sensors are generally used to measure wind and are ultrasonic devices, measuring the airflow speed and direction using the Doppler effect.

Depends on:

Here is some use cases of such sensors from a manufacturer sensor which we have used.
https://fttechnologies.com/case-studies.

This is part of a larger plan to support an airflow sensor in PX4. @dagar

The code is heavily based on the Airspeed Sensor

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 29, 2023
henrykotze added 7 commits November 29, 2023 14:51
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
- Need to add more tests, alongside a windy world environment

Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
@azeey
Copy link
Contributor

azeey commented Jun 14, 2024

@henrykotze sorry that this set of PRs has taken so long to review. Would you be able to provide the motivation for creating a new sensor instead of using AirSpeed sensor?

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey
Copy link
Contributor

azeey commented Jul 31, 2024

@henrykotze we are now in Feature freeze for Gazebo Ionic. Since PR is already open, I've applied the beta label which means it's slotted for the Ionic release if we can get it merged before 08/28/2024. Do you think that's feasible? If not, please let me know and I'll remove the beta label.

@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants