Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work in progress] Fix gz-sim on Windows #2392

Closed
wants to merge 2 commits into from

Conversation

traversaro
Copy link
Contributor

🦟 Bug fix

Fixes #

Summary

This work in progress PR permits to run gz sim on Windows. It is currently in draft, but I opened it to avoid the risk of losing the changes.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

traversaro and others added 2 commits April 30, 2024 18:31
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro traversaro requested a review from mjcarroll as a code owner April 30, 2024 16:36
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 30, 2024
@traversaro traversaro marked this pull request as draft April 30, 2024 16:36
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.89%. Comparing base (ab18888) to head (4bf5328).
Report is 91 commits behind head on gz-sim8.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2392      +/-   ##
===========================================
+ Coverage    65.75%   65.89%   +0.14%     
===========================================
  Files          327      327              
  Lines        31233    31314      +81     
===========================================
+ Hits         20537    20635      +98     
+ Misses       10696    10679      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey
Copy link
Contributor

azeey commented Aug 6, 2024

@traversaro are you planning to get this in for the Ionic release? If not, no worries, just let me know and I'll remove the beta label.

@azeey
Copy link
Contributor

azeey commented Aug 12, 2024

@traversaro, as far as I know the preferred direction here is to implement the standalone binaries, but we don't have a PR for that for gz-sim yet, so I'll go ahead and remove the beta label. My hope is to get back to gazebosim/gz-tools#7 once Ionic is released.

@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 12, 2024
@traversaro
Copy link
Contributor Author

@traversaro, as far as I know the preferred direction here is to implement the standalone binaries, but we don't have a PR for that for gz-sim yet, so I'll go ahead and remove the beta label.

Sorry, my bad, I forgot to reply. I totally agree, handling all the signal passing with Ruby proved to be impossible, see #2393 (comment) for more details. I think we can safely close this PR.

@traversaro traversaro closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants