Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 ➡️ 3 #512

Merged
merged 2 commits into from
Dec 23, 2020
Merged

2 ➡️ 3 #512

merged 2 commits into from
Dec 23, 2020

Conversation

chapulina
Copy link
Contributor

Forward-port

adlarkin and others added 2 commits December 2, 2020 08:51
@adlarkin
Clarify how sim time is interpreted in a System's step (#467)
6817a52 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@chapulina
2 ➡️ 3
d9195c4 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020 •
edited
Loading

Codecov Report

Merging #512 (d9195c4) into ign-gazebo3 (478dea6) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #512      +/-   ##
===============================================
- Coverage        77.61%   77.56%   -0.06%     
===============================================
  Files              208      208              
  Lines            11385    11385              
===============================================
- Hits              8837     8831       -6     
- Misses            2548     2554       +6
Impacted Files Coverage Δ
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
src/SimulationRunner.cc 93.59% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478dea6...d9195c4. Read the comment docs.

@chapulina chapulina merged commit ae2a1da into ign-gazebo3 Dec 23, 2020
@chapulina chapulina deleted the chapulina/2_to_3 branch December 23, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @nkoenig @adlarkin