GPS sensor in Gazebo #519
Closed
GPS sensor in Gazebo #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 30, 2020 19:39
Signed-off-by: Dre Westcook <dre.west@outlook.com>
Signed-off-by: Dre Westcook <dre.west@outlook.com>
ahcorde
requested changes
Dec 30, 2020
Comment on lines
+184
to
185
| </y> | ||
| <z> |
There was a problem hiding this comment.
Suggested change
| </y> | |
| <z> | |
| </y> | |
| <z> |
| @@ -0,0 +1,46 @@ | |||
| /* | |||
| * Copyright (C) 2019 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2019 Open Source Robotics Foundation | |
| * Copyright (C) 2020 Open Source Robotics Foundation |
Comment on lines
+865
to
+867
| _in.GpsSensor()->PositionNoise()); | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| _in.GpsSensor()->PositionNoise()); | |
| } | |
| _in.GpsSensor()->PositionNoise()); | |
| } |
| @@ -0,0 +1,239 @@ | |||
| /* | |||
| * Copyright (C) 2019 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2019 Open Source Robotics Foundation | |
| * Copyright (C) 2020 Open Source Robotics Foundation |
Comment on lines
+151
to
+155
| } | ||
|
|
||
|
|
||
| // set sensor parent | ||
| std::string parentName = _ecm.Component<components::Name>( |
There was a problem hiding this comment.
Suggested change
| } | |
| // set sensor parent | |
| std::string parentName = _ecm.Component<components::Name>( | |
| } | |
| // set sensor parent | |
| std::string parentName = _ecm.Component<components::Name>( |
| @@ -0,0 +1,66 @@ | |||
| /* | |||
| * Copyright (C) 2019 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2019 Open Source Robotics Foundation | |
| * Copyright (C) 2020 Open Source Robotics Foundation |
Comment on lines
+52
to
+55
| EntityComponentManager &_ecm) final; | ||
|
|
||
|
|
||
| /// Documentation inherited |
There was a problem hiding this comment.
Suggested change
| EntityComponentManager &_ecm) final; | |
| /// Documentation inherited | |
| EntityComponentManager &_ecm) final; | |
| /// Documentation inherited |
| @@ -0,0 +1,209 @@ | |||
| /* | |||
| * Copyright (C) 2019 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2019 Open Source Robotics Foundation | |
| * Copyright (C) 2020 Open Source Robotics Foundation |
Comment on lines
+154
to
+170
| // velocity should be negative in z | ||
| //EXPECT_GT(velocities.front().Z(), velocities.back().Z()); | ||
| //EXPECT_LT(velocities.back().Z(), 0.0); | ||
|
|
||
| // check gps sensor data | ||
|
|
||
| /* | ||
| // vertical position = world position - intial position | ||
| // so since gps is falling, vertical position should be negative | ||
| EXPECT_GT(firstMsg.vertical_position(), | ||
| lastMsg.vertical_position()); | ||
| EXPECT_LT(lastMsg.vertical_position(), 0.0); | ||
| // vertical velocity should be negative | ||
| EXPECT_GT(firstMsg.vertical_velocity(), | ||
| lastMsg.vertical_velocity()); | ||
| EXPECT_LT(lastMsg.vertical_velocity(), 0.0); | ||
| */ |
ahcorde
added
the
needs upstream release
This was referenced Dec 13, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
gazebosim/gz-sensors#23
My pull requests: (This PR would depend on the following: )
gazebosim/gz-sensors#72
(which then depends on)
gazebosim/sdformat#453
Use the ign-sensor::Gps in the gazebo sim by creating a Gps-system
This was by far the hardest one to get going, not least due to the "binary/source" issue as mentioned by gazebosim/gz-tools#8
As mentioned on the sdformat issue, I've only made two simple noise systems that get applied unilaterally to each of the components.. If this doesn't suite I could change it.
I'm also really hoping that the use of
sphericalCoords.PositionTransform()was correct because I wasn't quite sure on how it's meant to be used; or what a better way to use it ( ie: should the GPS store it's data in a SphericalCoords Type? )Some notes: