Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bounding box when model is deleted #675

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Currently, when a selected model is deleted, its bounding box is not deleted and moves to the origin:

aabb

With this PR, the box is correctly deleted.

Checklist

  • Signed all commits for DCO
  • Added tests: nothing in rendering has unit tests right now. We should add some.
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering labels Mar 9, 2021
@chapulina chapulina requested a review from iche033 as a code owner March 9, 2021 03:22
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #675 (1b446fb) into ign-gazebo4 (58cc8d3) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #675      +/-   ##
===============================================
- Coverage        65.01%   64.96%   -0.06%     
===============================================
  Files              232      232              
  Lines            16645    16649       +4     
===============================================
- Hits             10822    10816       -6     
- Misses            5823     5833      +10     
Impacted Files Coverage Δ
src/rendering/RenderUtil.cc 42.11% <0.00%> (-0.19%) ⬇️
src/SimulationRunner.cc 92.88% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cc8d3...1b446fb. Read the comment docs.

@chapulina chapulina merged commit d79aafd into ign-gazebo4 Mar 9, 2021
@chapulina chapulina deleted the chapulina/4/bb_delete branch March 9, 2021 18:27
adlarkin pushed a commit that referenced this pull request Mar 15, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔮 dome Ignition Dome GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants