-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone Ignition Gazebo executables #694
Conversation
This introduces the framework for two standalone executables: "server" and "gui" Signed-off-by: Michael Carroll <michael@openrobotics.org>
This can come in a minor, removed from beta |
We just merged the proof-of-concept for this in gazebosim/gz-transport#216, but it was a bit different since
while
Furthermore, the cmdgazebo.rb ruby command has complex logic for finding the world
it would be helpful to have a plan for what will be done in C++ and what will be done in ruby in order to proceed |
This seems reasonable, but I think that @ahcorde 's current work may allow us to not run them as separate processes. Part of this was an artifact of OGRE.
I think it would also be helpful to have this logic implemented in C++, so it could be accessible via API. |
All of that should be available from C++, except for the ERB parsing. That's why we had to duplicate a lot of the file locating logic from C++ into the Ruby script. It would be great to have that consistent regardless of whether we use the C++ API or the CLI. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@mjcarroll why is this PR closed? Is there any ongoing effort in this direction for ign-gazebo? |
This is out-of-date enough that I'm going to close this PR and re-open with a new implementation. |
🎉 Standalone Executables
Summary
Adds
ign-gazebo-server
andign-gazebo-gui
to be used as standalone executables invalgrind
,gdb
,heaptrack
, etc.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge