Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/code_check and update codecov #814

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #814 (af206f1) into ign-gazebo3 (01fc2ff) will increase coverage by 12.14%.
The diff coverage is 90.82%.

❗ Current head af206f1 differs from pull request most recent head fb93200. Consider uploading reports for the commit fb93200 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #814       +/-   ##
================================================
+ Coverage        65.71%   77.85%   +12.14%     
================================================
  Files              127      216       +89     
  Lines             6238    12150     +5912     
================================================
+ Hits              4099     9459     +5360     
- Misses            2139     2691      +552     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Component.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
... and 200 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cceec4e...fb93200. Read the comment docs.

@chapulina chapulina requested a review from j-rivero May 14, 2021 02:33
@chapulina
Copy link
Contributor Author

It's not often that we see 12 🟢 on ign-gazebo 😄

@ahcorde ahcorde merged commit 3d4caa8 into ign-gazebo3 May 17, 2021
@ahcorde ahcorde deleted the chapulina/codecheck branch May 17, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants