Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make halt motion act like a brake #830

Merged
merged 1 commit into from
May 24, 2021
Merged

Make halt motion act like a brake #830

merged 1 commit into from
May 24, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 24, 2021

🦟 Bug fix

Summary

Halt motion would leave joint velocity in place, which would allow a robot to continue moving. This PR makes HaltMotion act like a brake.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from azeey May 24, 2021 16:15
@github-actions github-actions bot added the 🔮 dome Ignition Dome label May 24, 2021
@mjcarroll mjcarroll self-requested a review May 24, 2021 16:16
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #830 (2998859) into ign-gazebo4 (996684c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #830      +/-   ##
===============================================
+ Coverage        65.73%   65.77%   +0.03%     
===============================================
  Files              241      241              
  Lines            17839    17841       +2     
===============================================
+ Hits             11727    11735       +8     
+ Misses            6112     6106       -6     
Impacted Files Coverage Δ
src/systems/physics/Physics.cc 71.68% <100.00%> (+0.06%) ⬆️
src/SimulationRunner.cc 94.01% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996684c...2998859. Read the comment docs.

@nkoenig nkoenig changed the title Make halt motiona act like a brake Make halt motion act like a brake May 24, 2021
@nkoenig nkoenig merged commit be5581f into ign-gazebo4 May 24, 2021
@nkoenig nkoenig deleted the halt_motion_halts branch May 24, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants