Enables confirmation dialog when closing Gazebo. #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
francocipollone
added
enhancement
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #850 +/- ##
================================================
+ Coverage 65.71% 77.94% +12.23%
================================================
Files 127 215 +88
Lines 6238 12077 +5839
================================================
+ Hits 4099 9414 +5315
- Misses 2139 2663 +524
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jun 14, 2021
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Done! |
francocipollone
removed
the
needs upstream release
chapulina
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related to issue #820
Summary
This feature of MainWindow was added here gazebosim/gz-gui#225
-->
needs upstream releaseIn this PR we only have to enable this behavior.
Test it
cd ign-gazebo git checkout francocipollone/citadel_confirmation_dialog colcon build --packages-select ign-gazebo3 ign gazeboNow try to close it!
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge